From c0f9043cf0cfad79cd831db321595903e98edfd4 Mon Sep 17 00:00:00 2001
From: Adirelle <adirelle@gmail.com>
Date: Thu, 16 May 2013 11:09:48 +0200
Subject: [PATCH] Fixed log messages and return codes when no repository
 identifier can be worked out from the URL.

---
 Redmine.pm | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/Redmine.pm b/Redmine.pm
index 89ed6b2..e068f2c 100644
--- a/Redmine.pm
+++ b/Redmine.pm
@@ -456,6 +456,10 @@ sub authz_handler {
 			WHERE p.identifier = ? AND r.is_default AND r.type = ?",
 			undef, $identifier, $cfg->{RepositoryType}
 		);
+		unless(defined $project_id) {
+			$r->log_reason("No matching project for ${identifier}");
+			return NOT_FOUND;
+		}
 
 	} elsif(my $repo_id = get_repository_identifier($r)) {
 		($identifier, $project_id, $is_public, $status) = $dbh->selectrow_array(
@@ -464,9 +468,15 @@ sub authz_handler {
 			WHERE ((r.is_default AND p.identifier = ?) OR r.identifier = ?) AND r.type = ?",
 			undef, $repo_id, $repo_id, $cfg->{RepositoryType}
 		);
-	}
+		unless(defined $project_id) {
+			$r->log_reason("No matching project for ${repo_id}");
+			return NOT_FOUND;
+		}
 
-	return NOT_FOUND unless defined $project_id;
+	} else {
+		# Cannot get a project out of the URL, we probably are on the parent path (e.g. /svn/)
+		return FORBIDDEN;
+	}
 
 	$is_public = is_true($is_public);