override of cidicts __getitem__

CHANGES.rst

@@ -0,0 +1,24 @@
+Changelog
+---------------
+
+0.1.5
++++++
+
+- Override of cidicts __getitem__ so that user.attrs['nonexistent'] won't raise an exception, but instead returns an empty list
+
+0.1.2
++++++
+
+- README.md to README.rst (pypi should show a nice README as well)
+
+0.1.1
++++++
+
+- fixed pretty print of binary attribute
+- fixed ldap.get sizelimit=1 exception for now
+- added try catch to api
+
+0.1
++++
+
+- Initial version, have to start somewhere

CHANGES.txt

@@ -1,5 +0,0 @@
-0.1   - initial version
-0.1.1 - fixed pretty print of binary attribute
-      - fixed ldap.get sizelimit=1 exception for now
-      - added try catch to api
-0.1.2 - README.md to README.rst

MANIFEST.in

@@ -1,4 +1,4 @@
-include CHANGES.txt
+include CHANGES.rst
 include LICENSE.txt
 include MANIFEST.in
 include README.rst

ldappr/connection.py

@@ -22,7 +22,7 @@ class Connection(object):
         # TODO: use the escape_filter_chars() and filter_format() functions
         """Get list of objects that match the search_filter
         :param search_filter: filter to find the objects
-        :return: list of LdapperObjects
+        :return: list of LdapperObjects (or empty list)
         """
         result = self.conn.search_s(self.search_base, ldap.SCOPE_SUBTREE,
                                     search_filter)

ldappr/ldapprobject.py

@@ -2,6 +2,17 @@ import ldap
 import ldif
 from ldap.cidict import cidict
 from StringIO import StringIO
+from string import lower
+
+
+class CustomCidict(cidict):
+    def __getitem__(self, key):
+        """Override of the __getitem__ method to return an empty list if a key
+        does not exist (instead of raising an exception)
+        """
+        if lower(key) in self.data:
+            return self.data[lower(key)]
+        return []
 
 
 class LdapprObject(object):
@@ -14,7 +25,7 @@ class LdapprObject(object):
         existing connection.
         """
         (self.dn, self.attributes) = result
-        self.attrs = cidict(self.attributes)
+        self.attrs = CustomCidict(self.attributes)
         self.conn = conn
 
     def __str__(self):

ldappr/test/test_ldappr.py

@@ -41,21 +41,15 @@ class TestLdappr(unittest.TestCase):
         ldap = connect_to(self.server, port=self.ldap_port)
         ldap.close()
 
-    # def test_server_down(self):
-    #     with self.assertRaises(ldap.SERVER_DOWN):
-    #         connect_to('wrong_server', self.bind_dn, self.password,
-    #                    port=self.ldap_port)
-    #
-    # def test_invalid_credentials(self):
-    #     with self.assertRaises(ldap.INVALID_CREDENTIALS):
-    #         connect_to(self.server, self.bind_dn, 'wrong_password',
-    #                    port=self.ldap_port)
-
     def test_get_attributes_from_ldapper_object(self):
         user = self.ldap.get('cn=jdoe')
         self.assertEqual(user.attrs['givenname'], ['John'])
         self.assertEqual(user.attrs['gIvEnNaMe'], ['John'])
 
+    def test_get_nonexisting_attribute_ldapper_object(self):
+        user = self.ldap.get('cn=jdoe')
+        self.assertEqual(user.attrs['nonexisting'], [])
+
     def test_search_instead_of_get(self):
         self.assertNotEqual(self.ldap.search('cn=jdoe'), [])