ukamnya
/
Redmine-mod-perl-auth
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed log messages and return codes when no repository identifier can be worked out from the URL.

master
Adirelle 2013-05-16 11:09:48 +02:00
parent 985a8d1f41
commit c0f9043cf0
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Redmine.pm
View File

@ -456,6 +456,10 @@ sub authz_handler {
WHERE p.identifier = ? AND r.is_default AND r.type = ?", WHERE p.identifier = ? AND r.is_default AND r.type = ?",
undef, $identifier, $cfg->{RepositoryType} undef, $identifier, $cfg->{RepositoryType}
); );
unless(defined $project_id) {
$r->log_reason("No matching project for ${identifier}");
return NOT_FOUND;
}
} elsif(my $repo_id = get_repository_identifier($r)) { } elsif(my $repo_id = get_repository_identifier($r)) {
($identifier, $project_id, $is_public, $status) = $dbh->selectrow_array( ($identifier, $project_id, $is_public, $status) = $dbh->selectrow_array(
@ -464,9 +468,15 @@ sub authz_handler {
WHERE ((r.is_default AND p.identifier = ?) OR r.identifier = ?) AND r.type = ?", WHERE ((r.is_default AND p.identifier = ?) OR r.identifier = ?) AND r.type = ?",
undef, $repo_id, $repo_id, $cfg->{RepositoryType} undef, $repo_id, $repo_id, $cfg->{RepositoryType}
); );
unless(defined $project_id) {
$r->log_reason("No matching project for ${repo_id}");
return NOT_FOUND;
} }
return NOT_FOUND unless defined $project_id; } else {
# Cannot get a project out of the URL, we probably are on the parent path (e.g. /svn/)
return FORBIDDEN;
}
$is_public = is_true($is_public); $is_public = is_true($is_public);